-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rianhughes/sequencer #1863
Closed
Closed
Rianhughes/sequencer #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a4a7a9
to
c201e98
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
==========================================
- Coverage 75.48% 75.08% -0.41%
==========================================
Files 97 103 +6
Lines 8676 9354 +678
==========================================
+ Hits 6549 7023 +474
- Misses 1545 1663 +118
- Partials 582 668 +86 ☔ View full report in Codecov by Sentry. |
6c9d942
to
0f24541
Compare
Co-authored-by: Ömer Faruk IRMAK <omerfirmak@gmail.com>
so the builder can commit the state diff to the db
and make core.State operate on `core.StateDiff`s instead. This will play nicer with how sequencer finalizes blocks.
Ignoring goroutine-safety for now. The mempool should only be Pop-ed by the builder anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging main...feature/sequencer into main, by cherry-picking