Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip handler tests #1829

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Unskip handler tests #1829

merged 1 commit into from
Aug 9, 2024

Conversation

kirugan
Copy link
Contributor

@kirugan kirugan commented Apr 16, 2024

fixes #1836

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (3cf58a1) to head (07a49b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
+ Coverage   75.61%   78.30%   +2.69%     
==========================================
  Files         101      101              
  Lines        9064     9064              
==========================================
+ Hits         6854     7098     +244     
+ Misses       1591     1339     -252     
- Partials      619      627       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kirugan kirugan marked this pull request as ready for review April 17, 2024 11:39
@kirugan kirugan force-pushed the kirugan/unskip-handler-tests branch from e857f3f to 88a3eda Compare April 23, 2024 09:45
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@derrix060 derrix060 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has some conflicts :)

@derrix060 derrix060 force-pushed the kirugan/unskip-handler-tests branch from 88a3eda to d0adb6b Compare August 9, 2024 15:20
@derrix060 derrix060 dismissed their stale review August 9, 2024 15:20

no more conflicts

Right now the only tests being skipped is the p2p tests

Co-authored-by: kirugan <kirill@nethermind.io>
@derrix060 derrix060 force-pushed the kirugan/unskip-handler-tests branch from d0adb6b to 07a49b3 Compare August 9, 2024 16:12
@derrix060 derrix060 merged commit 66f8828 into main Aug 9, 2024
10 checks passed
@derrix060 derrix060 deleted the kirugan/unskip-handler-tests branch August 9, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing tests for handlers
3 participants