Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve search experience for commands such as file, export #91

Merged
merged 4 commits into from
Sep 14, 2021

Conversation

jaydhulia
Copy link
Collaborator

Allows user to search by role name, account friendly name, account number

@jaydhulia jaydhulia changed the title [WIP] Improve search experience for commands such as file, export Improve search experience for commands such as file, export Sep 13, 2021
cmd/helpers.go Outdated

// Prompt the user
prompt := promptui.Select{
Label: "Select Role",
Label: "You can search for role name or account name/number or a combination of the two, e.g. prod appname",
Items: roles,
Size: 16,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump this down to 10? 16 is a little busy/crowded imo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, done!

Copy link
Contributor

@patricksanders patricksanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@jaydhulia jaydhulia merged commit b00a109 into master Sep 14, 2021
@jaydhulia jaydhulia deleted the jdhulia-search-v2 branch September 14, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants