Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow URL override for open links #63

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Conversation

patricksanders
Copy link
Contributor

In cases where ConsoleMe is configured to use mutual TLS, the API and web interface may be served from different URLs. This PR adds the ability to override the consoleme_url config entry with consoleme_open_url_override for the purpose of generating URLs for the open command.

Copy link
Collaborator

@jaydhulia jaydhulia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@patricksanders patricksanders merged commit f16e551 into master Apr 8, 2021
@patricksanders patricksanders deleted the fix/url-override branch April 8, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants