-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a open
command
#61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like what you've done here! The one hesitation I have here is the command name in relation to its default behavior. I think we should make weep link
output a link (to be used for sharing, etc) and add a weep console
command that opens the link in a browser. This second command will also be used for opening a console for a requested role.
creds/consoleme.go
Outdated
if resp.StatusCode != http.StatusOK { | ||
return "", parseError(resp.StatusCode, document) | ||
} | ||
var resourceURL map[string]string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should define a type for this response instead of using map[string]string
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
open
command that generates a deep ConsoleMe link, given an ARNopen
will open the browser, but this can be changed by including a flag