Skip to content

Commit

Permalink
fix: hopefully fix version for package, minor tweaks to release script
Browse files Browse the repository at this point in the history
  • Loading branch information
patricksanders committed Aug 26, 2021
1 parent 280d941 commit 3233cfc
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,14 @@ jobs:
with:
p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
-
name: Set version
run: echo "RELEASE_VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
-
name: Build, Sign, & Notarize Package
env:
AC_PASSWORD: ${{ secrets.AC_PASSWORD }}
VERSION: ${{ env.GITHUB_REF }}
VERSION: ${{ env.RELEASE_VERSION }}
run: |
./build/build_package.sh
-
Expand All @@ -101,4 +104,4 @@ jobs:
file: dist/macos/*.pkg
file_glob: true
tag: ${{ github.ref }}
overwrite: true
overwrite: true
11 changes: 6 additions & 5 deletions build/build_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function sign_package() {
}

function notarize() {
printf "πŸ” notarizing package..."
printf "πŸ” submitting package for notarization..."
output=$(xcrun altool \
--notarize-app \
--primary-bundle-id "com.netflix.weep" \
Expand All @@ -92,9 +92,10 @@ function notarize() {
--file "$FINAL_PACKAGE")
printf " done βœ… \n"
request_id=$(echo "$output" | grep RequestUUID | awk '{ print $3 }')
print "πŸ‘¨β€πŸ’» waiting for Apple\n"
printf "πŸ’‘ notarize request id is %s\n" "$request_id"
# give the server side a few seconds to sort things out
sleep 3
sleep 5
while true; do
status=$(check_notarize_status "$request_id")
printf "πŸ‘€ current status \"%s\"" "$status"
Expand All @@ -104,12 +105,12 @@ function notarize() {
break
;;
"failure")
printf ", exiting! πŸ”΄\n"
printf ", exiting! πŸ”΄ \n"
exit 1
;;
*)
printf ", not ready yet 😴\n"
sleep 5
printf ", not ready yet 😴 \n"
sleep 10
;;
esac
done
Expand Down

0 comments on commit 3233cfc

Please sign in to comment.