-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #756 (restore HTTP authentication support) #765
Conversation
@kennedyoliveira Here is the fix restoring basic authentication. Most of the code there is the test code, to make sure we do not miss this feature in the future. We do not use HTTP basic authentication as it is inherently insecure. |
Thanks @tbak, we have folks that use it in conjunction with SSL. Looks good! |
NetflixOSS » eureka » eureka-pull-requests #585 SUCCESS |
@tbak, thank you very much! I know it's not safe, but i was planing to use with SSL as @spencergibb, there is any alternative to this method for eureka? |
There's some SSL certificate security, but other than that... |
@kennedyoliveira We are using client side certificates, to authenticate both sides of the connection. |
👍 |
@tbak, sounds interesting, how is that? |
@kennedyoliveira Sorry, I have to take it back about the client side certificate validation. There are however some ways to do that (via SSL system properties or creating custom EurekaJerseyClient). |
@tbak, hmm i will search about that, i don't know much about SSL, just the basic, anyway, thank you for fixing it! If you have any source of documentation/books/ anything about this case and could tell me, i appreciate :D |
Fix issue #756 (restore HTTP authentication support)
No description provided.