Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #756 (restore HTTP authentication support) #765

Merged
merged 1 commit into from
Mar 17, 2016

Conversation

tbak
Copy link

@tbak tbak commented Mar 15, 2016

No description provided.

@tbak tbak added the 1.x label Mar 15, 2016
@tbak
Copy link
Author

tbak commented Mar 15, 2016

@kennedyoliveira Here is the fix restoring basic authentication. Most of the code there is the test code, to make sure we do not miss this feature in the future. We do not use HTTP basic authentication as it is inherently insecure.

@spencergibb
Copy link
Contributor

Thanks @tbak, we have folks that use it in conjunction with SSL. Looks good!

@cloudbees-pull-request-builder

NetflixOSS » eureka » eureka-pull-requests #585 SUCCESS
This pull request looks good

@kennedyoliveira
Copy link

@tbak, thank you very much! I know it's not safe, but i was planing to use with SSL as @spencergibb, there is any alternative to this method for eureka?

@spencergibb
Copy link
Contributor

There's some SSL certificate security, but other than that...

@tbak
Copy link
Author

tbak commented Mar 16, 2016

@kennedyoliveira We are using client side certificates, to authenticate both sides of the connection.

@qiangdavidliu
Copy link
Contributor

👍

@kennedyoliveira
Copy link

@tbak, sounds interesting, how is that?

@tbak
Copy link
Author

tbak commented Mar 17, 2016

@kennedyoliveira Sorry, I have to take it back about the client side certificate validation. There are however some ways to do that (via SSL system properties or creating custom EurekaJerseyClient).

@kennedyoliveira
Copy link

@tbak, hmm i will search about that, i don't know much about SSL, just the basic, anyway, thank you for fixing it! If you have any source of documentation/books/ anything about this case and could tell me, i appreciate :D

tbak pushed a commit that referenced this pull request Mar 17, 2016
Fix issue #756 (restore HTTP authentication support)
@tbak tbak merged commit 3a05eb3 into Netflix:master Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants