Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the point of c.n.h.c.RequestCollapserFactory.defaultNameCache #1220

Closed
mebigfatguy opened this issue May 26, 2016 · 1 comment
Closed
Labels

Comments

@mebigfatguy
Copy link
Contributor

Doesn't seem to be used, but has a relatively obtuse comment attached.

@mattrjacobs
Copy link
Contributor

If you look in a few other places in the codebase, AbstractCommand, HystrixCollapser, HystrixObservableCollapser, this pattern is used to safely turned a j.u.Class into a String once per-class, rather than on every command/collapser invocation.

So the pattern is valid, but I agree with you that the data structure you pointed out is unused. Do you want to submit a PR with its removal, or shall I? Thanks for all the cleanup efforts!

mebigfatguy added a commit to mebigfatguy/Hystrix that referenced this issue May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants