Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add number_of_generators for UniversalPolyRing #1795

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SoongNoonien
Copy link
Contributor

It seems like the poor universal polynomials were overlooked again ;-) I tried to make this somehow in line with the MPoly implementation. In the documentation examples for the MPolys we are testing number_of_generators for equality instead of simply printing the result like in the new examples for UniversalPolyRing. Is there a particular reason for this?

@lgoettgens
Copy link
Collaborator

Thanks for your PR. At first glance, this looks good. But since we don't have the compatibility tests with Hecke and Oscar running at the moment (AbstractAlgebra already jumped to the next minor version, but downstream hasn't been adapted), I would like to wait (a few days) until this is working again, just to make sure to not accidentally break something.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (ed58b14) to head (44a38d1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1795   +/-   ##
=======================================
  Coverage   88.01%   88.01%           
=======================================
  Files         118      118           
  Lines       30043    30044    +1     
=======================================
+ Hits        26442    26443    +1     
  Misses       3601     3601           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants