Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to set region. #617

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Allow users to set region. #617

merged 4 commits into from
Jun 26, 2023

Conversation

robputt
Copy link
Contributor

@robputt robputt commented Jun 24, 2023

Allow users to set region prior to ThingsIX onboard if not already set by gateway-rs.

Issue

  • Link:
  • Summary:

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@robputt robputt requested review from a team as code owners June 24, 2023 15:56
@robputt robputt marked this pull request as draft June 24, 2023 15:57
@robputt robputt marked this pull request as ready for review June 25, 2023 20:32
@shawaj
Copy link
Member

shawaj commented Jun 26, 2023

Also @robputt can the code smell be fixed at all?

@sonarcloud
Copy link

sonarcloud bot commented Jun 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@robputt robputt requested a review from shawaj June 26, 2023 17:49
@robputt robputt merged commit cfc8cfc into master Jun 26, 2023
14 checks passed
@robputt robputt deleted the allow_set_region branch June 26, 2023 18:19
shawaj added a commit to NebraLtd/helium-miner-software that referenced this pull request Jun 26, 2023
@shawaj
Bump diagnostics
63b3a49 
Refs:
NebraLtd/hm-diag#623
NebraLtd/hm-diag#619
NebraLtd/hm-diag#617
NebraLtd/hm-pyhelper#269
@shawaj shawaj mentioned this pull request Jun 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawaj shawaj shawaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robputt @shawaj