Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When not on Nebra OpenFleet, claim on dashboard page should have error #618

Closed
shawaj opened this issue Jun 24, 2023 · 2 comments · Fixed by #623
Closed

When not on Nebra OpenFleet, claim on dashboard page should have error #618

shawaj opened this issue Jun 24, 2023 · 2 comments · Fixed by #623

Comments

@shawaj
Copy link
Member

shawaj commented Jun 24, 2023

Currently, if you deploy our software on balenaCloud using the deploy with Balena button, the diagnostics page will still show "claim on dashboard" even though this isn't actually possible.

We should instead throw an error with a page saying that if people want to use dashboard / multi mining you need to be on Nebra OpenFleets from https://hub.nebra.com
@shawaj shawaj changed the title When not on Nebra OpenFleet, claim on dashboard page should fail When not on Nebra OpenFleet, claim on dashboard page should have error Jun 24, 2023
@shawaj
Copy link
Member Author

shawaj commented Jun 26, 2023

Will check for BALENA_API_URL=https://api.cloud.nebra.com and BALENA_APP_ID equal to one of ours...

shawaj added a commit that referenced this issue Jun 26, 2023
@shawaj
feat: show error page when trying to claim on dashboard and using bal…
e68c0bd 
…encloud

- add check for nebra fleets
- if not in nebra fleet (i.e. running on balenacloud or own openbalena instance) then when clicking claim on dashboard it goes to a specific error page

Closes: #618
@shawaj shawaj mentioned this issue Jun 26, 2023
Merged
4 tasks
@shawaj
Copy link
Member Author

shawaj commented Jun 26, 2023

Ref NebraLtd/hm-pyhelper#269

shawaj added a commit that referenced this issue Jun 26, 2023
@shawaj
feat: show error page when trying to claim on dashboard and using bal…
294b5fe 
…enacloud

- add check for nebra fleets
- if not in nebra fleet (i.e. running on balenacloud or own openbalena instance) then when clicking claim on dashboard it goes to a specific error page

Closes: #618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: show error page when trying to claim on dashboard and using balenacloud NebraLtd/hm-diag
1 participant
@shawaj