fix: exit(0) causes ANR due to destroyed mutex

[mukaschultze]

Description

When initializing the runtime in direct boot mode the exit(0) IO cleanup causes a SIGABRT with the following message:

libc    : FORTIFY: pthread_mutex_destroy called on a destroyed mutex (0x759399de1718)

This SIGABRT is caught by the SIG_handler which in turn throws a tsn::NativeScriptException. I'm not exactly sure what catches this NativeScriptException, but whatever it is either deadlocks or keeps re-throwing it until the device runs out of memory.

android/test-app/runtime/src/main/cpp/Runtime.cpp

Lines 49 to 66 in ba50f03

	void SIG_handler(int sigNumber) {
	stringstream msg;
	msg << "JNI Exception occurred (";
	switch (sigNumber) {
	case SIGABRT:
	msg << "SIGABRT";
	break;
	case SIGSEGV:
	msg << "SIGSEGV";
	break;
	default:
	// Shouldn't happen, but for completeness
	msg << "Signal #" << sigNumber;
	break;
	}
	msg << ").\n=======\nCheck the 'adb logcat' for additional information about the error.\n=======\n";
	throw NativeScriptException(msg.str());
	}

This bug shows up as an ANR (App not responding) in Crashlytics and Google Play console (as reported in NativeScript/NativeScript#10527).

The same issue was reported on flutter/flutter#103587, which leads me to believe this is not specific to Nativescript's runtime.

My proposed solution is to use _Exit(0) instead, which doesn't trigger any cleanup process and simply ends the process.

Full error below:

08-28 13:56:32.187  1506  1506 D TNS.Runtime: V8 version 10.3.22
08-28 13:56:32.191  1506  1506 E TNS.error: metadata folder couldn't be opened! (Error: 2) 
--------- beginning of crash
08-28 13:56:32.191  1506  1506 F libc    : FORTIFY: pthread_mutex_destroy called on a destroyed mutex (0x759399de1718)
08-28 13:56:32.191  1506  1506 F TNS.Native: JNI Exception occurred (SIGABRT).
08-28 13:56:32.191  1506  1506 F TNS.Native: =======
08-28 13:56:32.191  1506  1506 F TNS.Native: Check the 'adb logcat' for additional information about the error.
08-28 13:56:32.191  1506  1506 F TNS.Native: =======
08-28 13:56:32.191  1506  1506 E libc++abi: terminating with uncaught exception of type tns::NativeScriptException

Related Pull Requests

#1712
NativeScript/plugins#262
NativeScript/NativeScript#10527

Does your pull request have unit tests?