feat(stark-demo): add the ngx form error to the showcase #1361

nicanac · 2019-07-17T11:43:34Z

ISSUES CLOSED: #1195

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#-commit-message-guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

Add the ngx form error to the showcase

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:#1195

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

showcase/src/app/app-menu.config.ts

showcase/src/assets/translations/en.json

...active-forms-with-ngx-form-errors/demo-reactive-forms-with-ngx-form-errors-page.component.ts

...c/assets/examples/reactive-forms-with-ngx-form-errors/reactive-forms-with-ngx-form-errors.ts

showcase/src/app/app-menu.config.ts

showcase/src/app/demo-ui/parent-error-state-matcher.ts

...tive-forms-with-ngx-form-errors/demo-reactive-forms-with-ngx-form-errors-page.component.scss

showcase/src/app/demo-ui/components/card/card.component.ts

christophercr

Some remarks :p

showcase/src/app/demo-ui/components/card/card.component.ts

showcase/src/app/demo-ui/password-validator.ts

showcase/src/app/demo-ui/routes.ts

showcase/src/app/app-menu.config.ts

showcase/src/app/demo-ui/pages/index.ts

...active-forms-with-ngx-form-errors/demo-reactive-forms-with-ngx-form-errors-page.component.ts

...assets/examples/reactive-forms-with-ngx-form-errors/reactive-forms-with-ngx-form-errors.html

christophercr

Some remarks, and also, the example now contains only half of the implementation, we need to also show the configuration needed for the NgxFormErrorsModule and the entryComponents. I suggest to add another section in the page explaining that, something like we did in https://stark.nbb.be/showcase/latest/demo-rbac/authorization-service

Don't forget to rebase your branch and squash your commits 😉

Sorry for the delay... I almost forget about this PR :p

...assets/examples/reactive-forms-with-ngx-form-errors/reactive-forms-with-ngx-form-errors.scss

showcase/src/app/welcome/pages/reactive-form-errors/components/card/card.component.ts

...ase/src/app/welcome/pages/reactive-form-errors/demo-reactive-form-errors-page.component.html

...assets/examples/reactive-forms-with-ngx-form-errors/reactive-forms-with-ngx-form-errors.html

showcase/src/assets/translations/en.json

...ase/src/app/welcome/pages/reactive-form-errors/demo-reactive-form-errors-page.component.html

christophercr · 2019-08-19T12:19:07Z

@nicanac thinking a bit more on this, in fact it is not necessary to add the other section to show the configuration needed for the NgxFormErrorsModule and the entryComponents that I mentioned before... normally that is already explained in the docs of the ngx-form-errors package... so just adding the Reference link in the demo page should be enough... what do you think?

That way it is safer as we don't need to duplicate documentation...

nicanac · 2019-08-20T06:03:58Z

@nicanac thinking a bit more on this, in fact it is not necessary to add the other section to show the configuration needed for the NgxFormErrorsModule and the entryComponents that I mentioned before... normally that is already explained in the docs of the ngx-form-errors package... so just adding the Reference link in the demo page should be enough... what do you think?

That way it is safer as we don't need to duplicate documentation...

@christophercr , I do agree, it's the reason why I didn't include it at first.
I'll add the reference link to the demo page, and we should be fine.

coveralls · 2019-08-22T08:08:46Z

Coverage remained the same at 94.209% when pulling fab34a2 on nicanac:feature/ngx-forms into 2878029 on NationalBankBelgium:master.

christophercr

Still some translations to be replaced in the example files. And also, the name of the example files is wrong, it should be reactive-form-errors.xxx (currently it has an extra s in forms) so the exmple files cannot be found:

GET http://localhost:3000/assets/examples/reactive-form-errors/reactive-form-errors.html 404 (Not Found)
GET http://localhost:3000/assets/examples/reactive-form-errors/reactive-form-errors.scss 404 (Not Found)
GET http://localhost:3000/assets/examples/reactive-form-errors/reactive-form-errors.ts 404 (Not Found)

Nice thank you, Haven't seen it. It's solved.

showcase/src/assets/examples/reactive-forms-errors/reactive-forms-errors.html

showcase/src/assets/translations/fr.json

...ase/src/app/welcome/pages/reactive-form-errors/demo-reactive-form-errors-page.component.html

christophercr

Some comments

showcase/src/assets/translations/fr.json

showcase/src/app/welcome/pages/reactive-form-errors/demo-reactive-form-errors-page.component.ts

ISSUES CLOSED: NationalBankBelgium#1195

christophercr

Just one small remark.... almost there! 😉

showcase/src/assets/translations/fr.json

carlo-nomes

I get this warning in chrome devtools when on the page.

Also, a couple of notes

showcase/src/app/demo-ui/demo-ui.module.ts

carlo-nomes · 2019-08-27T10:19:39Z

...ase/src/app/welcome/pages/reactive-form-errors/demo-reactive-form-errors-page.component.scss

+button {
+  margin: 8px;
+}
+.grid {


grid won't work in IE, maybe you could use flexbox instead

showcase/src/app/welcome/pages/reactive-form-errors/parent-error-state-matcher.ts

showcase/src/app/welcome/pages/reactive-form-errors/password-validator.ts

carlo-nomes · 2019-08-27T10:36:38Z

showcase/src/app/welcome/pages/reactive-form-errors/demo-reactive-form-errors-page.component.ts

+	public ngOnInit(): void {
+		this.formGroup = this.formBuilder.group({
+			username: [undefined, Validators.required],
+			matchingPasswords: new FormGroup(


could you use the formbuilder for the group and form controls?

showcase/src/app/welcome/pages/reactive-form-errors/demo-reactive-form-errors-page.component.ts

showcase/src/app/welcome/pages/reactive-form-errors/password-validator.ts

showcase/src/app/welcome/welcome.module.ts

carlo-nomes

Also, don't forget to update the example when you make changes. 😄

SuperITMan · 2020-03-24T17:17:42Z

Superseded by #1721.

nicanac requested a review from SuperITMan July 17, 2019 11:43

SuperITMan added comp: stark-showcase type: feature labels Jul 17, 2019

SuperITMan added this to the 10.0.0-rc.0 milestone Jul 17, 2019

SuperITMan requested changes Jul 17, 2019

View reviewed changes

christophercr suggested changes Jul 24, 2019

View reviewed changes

SuperITMan modified the milestones: 10.0.0-rc.0, 10.0.0-rc.1 Aug 6, 2019

christophercr suggested changes Aug 19, 2019

View reviewed changes

nicanac force-pushed the feature/ngx-forms branch 8 times, most recently from cff4490 to 881ffb0 Compare August 22, 2019 07:47

nicanac requested review from christophercr and SuperITMan August 22, 2019 14:06

christophercr suggested changes Aug 23, 2019

View reviewed changes

nicanac force-pushed the feature/ngx-forms branch 2 times, most recently from 033df4e to 7a64264 Compare August 23, 2019 13:28

christophercr reviewed Aug 26, 2019

View reviewed changes

feat(stark-demo): add the ngx form error to the showcase

fab34a2

ISSUES CLOSED: NationalBankBelgium#1195

christophercr reviewed Aug 27, 2019

View reviewed changes

showcase/src/assets/translations/fr.json Show resolved Hide resolved

christophercr requested a review from carlo-nomes August 27, 2019 07:41

carlo-nomes reviewed Aug 27, 2019

View reviewed changes

carlo-nomes suggested changes Aug 27, 2019

View reviewed changes

christophercr modified the milestones: 10.0.0-rc.1, 10.0.0-rc.2 Sep 28, 2019

SuperITMan modified the milestones: 10.0.0-rc.2, 10.0.0-rc.3 Oct 29, 2019

SuperITMan modified the milestones: 10.0.0-rc.3, 10.0.0-rc.4 Jan 7, 2020

SuperITMan modified the milestones: 10.0.0-rc.4, 10.0.0 Feb 4, 2020

SuperITMan modified the milestones: 10.0.0, 10.0.1 Mar 10, 2020

christophercr mentioned this pull request Mar 16, 2020

feat(showcase): add the ngx-form-errors to the showcase #1721

Merged

3 tasks

christophercr modified the milestones: 10.0.1, 10.1.0 Mar 19, 2020

SuperITMan closed this Mar 24, 2020

SuperITMan removed this from the 10.1.0 milestone Mar 24, 2020

SuperITMan mentioned this pull request Oct 13, 2024

[Snyk] Upgrade core-js from 3.17.3 to 3.38.1 #3924

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(stark-demo): add the ngx form error to the showcase #1361

feat(stark-demo): add the ngx form error to the showcase #1361

nicanac commented Jul 17, 2019

christophercr left a comment

christophercr left a comment •

edited

Loading

christophercr commented Aug 19, 2019 •

edited

Loading

nicanac commented Aug 20, 2019

coveralls commented Aug 22, 2019 •

edited

Loading

christophercr left a comment •

edited

Loading

christophercr left a comment

christophercr left a comment

carlo-nomes left a comment

carlo-nomes Aug 27, 2019

carlo-nomes Aug 27, 2019

carlo-nomes left a comment

SuperITMan commented Mar 24, 2020

feat(stark-demo): add the ngx form error to the showcase #1361

feat(stark-demo): add the ngx form error to the showcase #1361

Conversation

nicanac commented Jul 17, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

christophercr left a comment

Choose a reason for hiding this comment

christophercr left a comment • edited Loading

Choose a reason for hiding this comment

christophercr commented Aug 19, 2019 • edited Loading

nicanac commented Aug 20, 2019

coveralls commented Aug 22, 2019 • edited Loading

christophercr left a comment • edited Loading

Choose a reason for hiding this comment

christophercr left a comment

Choose a reason for hiding this comment

christophercr left a comment

Choose a reason for hiding this comment

carlo-nomes left a comment

Choose a reason for hiding this comment

carlo-nomes Aug 27, 2019

Choose a reason for hiding this comment

carlo-nomes Aug 27, 2019

Choose a reason for hiding this comment

carlo-nomes left a comment

Choose a reason for hiding this comment

SuperITMan commented Mar 24, 2020

christophercr left a comment •

edited

Loading

christophercr commented Aug 19, 2019 •

edited

Loading

coveralls commented Aug 22, 2019 •

edited

Loading

christophercr left a comment •

edited

Loading