Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showcase: ngx-form-errors - we should integrate the module and present it #1195

Closed
SuperITMan opened this issue Mar 15, 2019 · 0 comments · Fixed by #1721
Closed

showcase: ngx-form-errors - we should integrate the module and present it #1195

SuperITMan opened this issue Mar 15, 2019 · 0 comments · Fixed by #1721
Assignees
@christophercr
Labels
comp: stark-showcase type: feature
Milestone
12.0.0-beta.0

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The errors are not well managed in the showcase application. We made a new module @nationalbankbelfium/ngx-form-errors and we don't promote it.

Expected behavior

We should promote our new module and use in our showcase app to handle correctly all the errors we have.

What is the motivation / use case for changing the behavior?

Improve the showcase.
@SuperITMan SuperITMan added this to the 10.0.0-beta.7 milestone Mar 15, 2019
@SuperITMan SuperITMan modified the milestones: 10.0.0-beta.8, 10.0.0-rc.0 Apr 29, 2019
@nicanac nicanac self-assigned this Jun 5, 2019
nicanac added a commit to nicanac/stark that referenced this issue Jun 11, 2019
@nicanac
feat(stark-demo): integrate ngx-form-errors to the showcase
9e6372b 
ISSUES CLOSED: NationalBankBelgium#1195
@nicanac nicanac mentioned this issue Jun 11, 2019
Closed
2 tasks
nicanac added a commit to nicanac/stark that referenced this issue Jun 28, 2019
@nicanac
feat(stark-demo): integrate ngx-form-errors to the showcase
77135c5 
ISSUES CLOSED: NationalBankBelgium#1195
nicanac added a commit to nicanac/stark that referenced this issue Jun 28, 2019
@nicanac
feat(stark-demo): add the reactive forms with ngxformserrors to the s…
56e3a01 
…howcase

implementation of the form in the showcase
I've added
an entry in the navigation panel
A card
component for a custom style used in the error message
some translation tags

ISSUES CLOSED: NationalBankBelgium#1195
nicanac added a commit to nicanac/stark that referenced this issue Jun 28, 2019
@nicanac
feat(stark-demo): add entry in navigation panel
c5bdde6 
ISSUES CLOSED: NationalBankBelgium#1195
@nicanac nicanac mentioned this issue Jun 28, 2019
Closed
2 tasks
nicanac added a commit to nicanac/stark that referenced this issue Jul 16, 2019
@nicanac
feat(stark-demo): add the ngx form error to the showcase
490d18a 
ISSUES CLOSED: NationalBankBelgium#1195
This was referenced Jul 16, 2019
Closed
Closed
@SuperITMan SuperITMan modified the milestones: 10.0.0-rc.0, 10.0.0-rc.1 Aug 6, 2019
nicanac added a commit to nicanac/stark that referenced this issue Aug 21, 2019
@nicanac
feat(stark-demo): add the ngx form error to the showcase
cdb77cb 
ISSUES CLOSED: NationalBankBelgium#1195

fix(stark-demo): resolve an issue with incorrect importe of angular material

feat(stark-demo): imporve code and move files to fit to stark framework

feat(stark-demo): remove unused folder and files

feat(stark-demo): moving and Renaming files as well as add missing translation

feat(stark-demo): fix an issue with the usage of the logger

feat(stark-demo): split log

feat(stark-demo): Add the reactive forms errors demo page

feat(stark-demo): split logs

Add ngx forms error page to showcase
nicanac added a commit to nicanac/stark that referenced this issue Aug 21, 2019
@nicanac
feat(stark-demo): add the ngx form error to the showcase
33b64ba 
ISSUES CLOSED: NationalBankBelgium#1195
nicanac added a commit to nicanac/stark that referenced this issue Aug 21, 2019
@nicanac
feat(stark-demo): add the ngx form error to the showcase
cff4490 
ISSUES CLOSED: NationalBankBelgium#1195
@christophercr christophercr modified the milestones: 10.0.1, 10.1.0 Mar 19, 2020
christophercr pushed a commit to christophercr/stark that referenced this issue Mar 20, 2020
@nicanac @christophercr
feat(showcase): add the ngx-form-errors demo to the showcase
f34f5a8 
ISSUES CLOSED: NationalBankBelgium#1195
christophercr pushed a commit to christophercr/stark that referenced this issue Mar 25, 2020
@nicanac @christophercr
feat(showcase): add the ngx-form-errors demo to the showcase
33c572a 
ISSUES CLOSED: NationalBankBelgium#1195
@SuperITMan SuperITMan modified the milestones: 10.1.0, 10.2.0 Jul 24, 2020
christophercr added a commit to christophercr/stark that referenced this issue Aug 23, 2020
@christophercr
feat(showcase): add the ngx-form-errors demo to the showcase
3442e87 
ISSUES CLOSED: NationalBankBelgium#1195
christophercr added a commit to christophercr/stark that referenced this issue Aug 23, 2020
@christophercr
feat(showcase): add the ngx-form-errors demo to the showcase
7e8e5b8 
ISSUES CLOSED: NationalBankBelgium#1195
@SuperITMan SuperITMan modified the milestones: 10.2.0, 11.0.0 Mar 10, 2021
christophercr added a commit to christophercr/stark that referenced this issue May 12, 2021
@christophercr
feat(showcase): add the ngx-form-errors demo to the showcase
7ce393a 
ISSUES CLOSED: NationalBankBelgium#1195
christophercr added a commit to christophercr/stark that referenced this issue May 12, 2021
@christophercr
feat(showcase): add the ngx-form-errors demo to the showcase
a839e85 
ISSUES CLOSED: NationalBankBelgium#1195
christophercr added a commit to christophercr/stark that referenced this issue May 12, 2021
@christophercr
feat(showcase): add the ngx-form-errors demo to the showcase
b119bc4 
ISSUES CLOSED: NationalBankBelgium#1195
christophercr added a commit to christophercr/stark that referenced this issue May 12, 2021
@christophercr
feat(showcase): add the ngx-form-errors demo to the showcase
4a98d3c 
ISSUES CLOSED: NationalBankBelgium#1195
@SuperITMan SuperITMan modified the milestones: 12.0.0, 12.0.0-beta.0 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophercr christophercr

Labels
comp: stark-showcase type: feature
Projects
None yet
Milestone
12.0.0-beta.0
3 participants
@christophercr @SuperITMan @nicanac