improving codecov attempt

NathanCheshire · Oct 27, 2023 · 581d88e · 581d88e
1 parent 74dda31
commit 581d88e
Show file tree

Hide file tree

Showing 2 changed files with 51 additions and 13 deletions.
diff --git a/src/main/java/com/github/natche/jrobohash/enums/UseGravatar.java b/src/main/java/com/github/natche/jrobohash/enums/UseGravatar.java
@@ -10,17 +10,23 @@ public enum UseGravatar {
     /**
      * Gravatar should be used.
      */
-    YES,
+    YES("yes"),
 
     /**
      * Gravatar should not be used.
      */
-    NO,
+    NO("no"),
 
     /**
      * Gravatar should be used AND the provided string has already been hashed used MD5.
      */
-    HASHED;
+    HASHED("hashed");
+
+    private final String urlParameterName;
+
+    UseGravatar(String urlParameterName) {
+        this.urlParameterName = urlParameterName;
+    }
 
     /**
      * Constructs a URL parameter for this Gravatar state.
@@ -41,10 +47,6 @@ public String constructUrlParameter(boolean firstParameter) {
      * @return the URL parameter representation for this use Gravatar
      */
     public String getUrlParameterRepresentation() {
-        return switch (this) {
-            case NO -> "no";
-            case YES -> "yes";
-            case HASHED -> "hashed";
-        };
+        return urlParameterName;
     }
 }
diff --git a/src/test/java/com/github/natche/jrobohash/request/RoboHashRequestBuilderImplTest.java b/src/test/java/com/github/natche/jrobohash/request/RoboHashRequestBuilderImplTest.java
@@ -208,11 +208,47 @@ void testEquals() {
         assertNotEquals(implementationOne, differentOne);
         assertNotEquals(implementationOne, new Object());
 
-        RoboHashRequestBuilder differingImageSets1 = new RoboHashRequestBuilderImpl("key1", true)
-                .setImageSets(ImmutableList.of(ImageSet.KITTENS));
-        RoboHashRequestBuilder differingImageSets2 = new RoboHashRequestBuilderImpl("key1", true)
-                .setImageSets(ImmutableList.of(ImageSet.HUMANS));
-        assertNotEquals(differingImageSets1, differingImageSets2);
+        assertNotEquals(
+                new RoboHashRequestBuilderImpl("key1"),
+                new RoboHashRequestBuilderImpl("key2"));
+        assertNotEquals(
+                new RoboHashRequestBuilderImpl("key1", true),
+                new RoboHashRequestBuilderImpl("key1", false));
+        assertNotEquals(
+                new RoboHashRequestBuilderImpl("key1")
+                        .setImageSets(ImmutableList.of(ImageSet.HUMANS)),
+                new RoboHashRequestBuilderImpl("key1")
+                        .setImageSets(ImmutableList.of(ImageSet.KITTENS)));
+        assertNotEquals(
+                new RoboHashRequestBuilderImpl("key1")
+                        .setBackgroundSet(BackgroundSet.SPIRAL_AND_PATTERNS),
+                new RoboHashRequestBuilderImpl("key1")
+                        .setBackgroundSet(BackgroundSet.OUTSIDE));
+        assertNotEquals(
+                new RoboHashRequestBuilderImpl("key1")
+                        .setWidth(200),
+                new RoboHashRequestBuilderImpl("key1")
+                        .setWidth(201));
+        assertNotEquals(
+                new RoboHashRequestBuilderImpl("key1")
+                        .setHeight(200),
+                new RoboHashRequestBuilderImpl("key1")
+                        .setHeight(201));
+        assertNotEquals(
+                new RoboHashRequestBuilderImpl("key1")
+                        .setUseGravatar(UseGravatar.HASHED),
+                new RoboHashRequestBuilderImpl("key1")
+                        .setUseGravatar(UseGravatar.YES));
+        assertNotEquals(
+                new RoboHashRequestBuilderImpl("key1")
+                        .setIgnoreExtension(false),
+                new RoboHashRequestBuilderImpl("key1")
+                        .setIgnoreExtension(true));
+        assertNotEquals(
+                new RoboHashRequestBuilderImpl("key1")
+                        .setImageExtension(ImageExtension.JPEG),
+                new RoboHashRequestBuilderImpl("key1")
+                        .setImageExtension(ImageExtension.PNG));
     }
 
     /**