Fix the microphone test #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the microphone test that comes up during configuration. I switched from using the local_mic to mic_synchronous for the microphone, plus fixed the basic Mic __init__ method to not fail if some of the options being passed in through kwargs are missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the microphone test that comes up during configuration.
I switched from using the local_mic to mic_synchronous for the microphone, plus fixed the basic Mic init method to not fail if some of the options being passed in through kwargs are missing.
Related Issue
input/output device testing not working #408
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: