Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Alsa #407

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

aaronchantrill
Copy link
Contributor

@aaronchantrill aaronchantrill commented Jun 5, 2024

Description

When the asynchronous mic was introduced, some formatting changes were made that were not copied into the Alsa audio engine plugin.

Related Issue

Alsa engine not working #406

Motivation and Context

I'm just trying to use the Alsa engine with Naomi, mostly because right now, running inside the docker container, we don't have pulseaudio or pipewire working yet. The devices pyaudio can see are not compatible with any arbitrary bitrate and format. Plughw alsa devices do the audio format conversions on the fly so they can play anything, which is also what we use pulseaudio/pipewire for.

How Has This Been Tested?

Tested by running Naomi with alsa selected as the audio engine, also by running unittests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

When the asynchronous mic was introduced, some formatting changes
were made that were not copied into the Alsa audio engine plugin.
Removed some pyaudio code that I copied into the alsa audio engine
plugin while fixing some of the formatting.
@aaronchantrill aaronchantrill merged commit eb79b80 into NaomiProject:naomi-dev Jun 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alsa engine not working
1 participant