Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework some of the result classes #288

Merged
merged 3 commits into from
May 4, 2023
Merged

Rework some of the result classes #288

merged 3 commits into from
May 4, 2023

Conversation

nnansters
Copy link
Contributor

In response to the needs of Nikos in the data quality calculators I've done some quick rework to the Result class hierarchy, introducing some new abstract classes to inherit from (until we can get rid of those nasty components).

Also refactored the filter behavior across the different levels of the class hierarchy to build on top of each other.

Signed-off-by: Niels Nuyttens <niels@nannyml.com>
Signed-off-by: Niels Nuyttens <niels@nannyml.com>
@nnansters nnansters requested a review from nikml as a code owner May 3, 2023 19:16
@nnansters
Copy link
Contributor Author

@michael-nml FYI

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (18fe766) 79.95% compared to head (fc9d982) 80.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   79.95%   80.01%   +0.06%     
==========================================
  Files          82       82              
  Lines        6546     6536      -10     
  Branches     1040     1037       -3     
==========================================
- Hits         5234     5230       -4     
+ Misses       1049     1043       -6     
  Partials      263      263              
Impacted Files Coverage Δ
nannyml/base.py 82.29% <100.00%> (+1.80%) ⬆️
nannyml/data_quality/missing/result.py 92.00% <100.00%> (ø)
nannyml/data_quality/unseen/result.py 92.30% <100.00%> (ø)
...l/drift/multivariate/data_reconstruction/result.py 92.85% <100.00%> (ø)
nannyml/drift/univariate/result.py 93.42% <100.00%> (ø)
nannyml/performance_calculation/result.py 78.94% <100.00%> (-1.70%) ⬇️
...performance_estimation/confidence_based/metrics.py 95.76% <100.00%> (+0.13%) ⬆️
...performance_estimation/confidence_based/results.py 100.00% <100.00%> (ø)
...rmance_estimation/direct_loss_estimation/result.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Niels Nuyttens <niels@nannyml.com>
Copy link
Collaborator

@michael-nml michael-nml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Filter refactor is a nice improvement 👌

@nnansters nnansters merged commit 0a2bc14 into main May 4, 2023
@nnansters nnansters deleted the feat/rework-results branch May 4, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants