Fix filtering for components in CBPE result #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
=======================================
Coverage 74.72% 74.72%
=======================================
Files 109 109
Lines 9702 9703 +1
Branches 1750 1750
=======================================
+ Hits 7250 7251 +1
Misses 1965 1965
Partials 487 487 ☔ View full report in Codecov by Sentry. |
nnansters
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes filtering for components in CBPE results.
The bug was introduced in #288 where the metric assignment on the
nannyml.performance_estimation.confidence_based.results.Resultclass was removed in favour of the base class. Performance calculation was not impacted.