Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ issue 589 override prompt self check facts #621

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

Pouyanpi
Copy link
Collaborator

This PR resolves #589

@Pouyanpi Pouyanpi added status: needs info Issues that require more information from the reporter to proceed. status: in progress Issues that are currently being worked on. labels Jul 10, 2024
@Pouyanpi Pouyanpi added this to the v0.10.0 milestone Jul 10, 2024
@Pouyanpi Pouyanpi self-assigned this Jul 10, 2024
@drazvan
Copy link
Collaborator

drazvan commented Jul 11, 2024

Looks good, @Pouyanpi. When you mark this as ready and fix the signature for the commits, we can merge.

@Pouyanpi Pouyanpi force-pushed the fix/issue-589-override-prompt-self-check-facts branch from 291c5e8 to c9603da Compare July 11, 2024 10:46
@drazvan
Copy link
Collaborator

drazvan commented Aug 20, 2024

@Pouyanpi: can you solve the conflicts and push again. Thanks!

@Pouyanpi
Copy link
Collaborator Author

@Pouyanpi: can you solve the conflicts and push again. Thanks!

Done!

@Pouyanpi Pouyanpi removed status: needs info Issues that require more information from the reporter to proceed. status: in progress Issues that are currently being worked on. labels Aug 20, 2024
@drazvan drazvan marked this pull request as ready for review August 21, 2024 10:18
@drazvan drazvan self-requested a review August 21, 2024 10:18
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍.

@drazvan drazvan merged commit fd8e102 into develop Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Overriding Prompt of SELF_CHECK_FACTS Task
2 participants