Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Got It AI's Truthchecking service for RAG applications #370

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

mlmonk
Copy link
Contributor

@mlmonk mlmonk commented Mar 1, 2024

Adds a third party hallucination detection output rail built by Got It AI. It requires an api key to work (similar to the ActiveFence integration). Relevant information has been updated in the documentation as well.

In addition, for now, the benchmarking results have been with Nvidia through internal channels.

@drazvan drazvan self-assigned this Mar 6, 2024
@drazvan drazvan added the enhancement New feature or request label Mar 6, 2024
@drazvan drazvan added this to the v0.9.0 milestone Mar 6, 2024
Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍 .
Just a few points to address (see the comments).

nemoguardrails/library/gotitai/actions.py Outdated Show resolved Hide resolved
nemoguardrails/library/gotitai/actions.py Show resolved Hide resolved
nemoguardrails/library/gotitai/flows.co Outdated Show resolved Hide resolved
@drazvan drazvan added the status: in progress Issues that are currently being worked on. label Mar 6, 2024
@mlmonk mlmonk requested a review from drazvan March 20, 2024 20:09
@drazvan
Copy link
Collaborator

drazvan commented Apr 12, 2024

Looks good 👍 . We'll merge next week after the patch release we have planned.

@drazvan drazvan modified the milestones: v0.8.2, v0.10.0 Apr 15, 2024
@drazvan drazvan merged commit 9e65111 into NVIDIA:develop Apr 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status: in progress Issues that are currently being worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants