Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure is supported #242

Merged
merged 1 commit into from
Jan 12, 2024
Merged

azure is supported #242

merged 1 commit into from
Jan 12, 2024

Conversation

magiccpp
Copy link
Contributor

@magiccpp magiccpp commented Jan 7, 2024

Azure support is added.
In config.xml, you could configure 'azure' as provider, like:
models:

  • type: main
    engine: azure
    model: gpt-4-1106-preview
    parameters:
    azure_endpoint:
    api_version: 2023-07-01-preview
    deployment_name:
    api_key:

@drazvan drazvan self-requested a review January 11, 2024 13:59
@drazvan drazvan added this to the v0.7.0 milestone Jan 11, 2024
@drazvan
Copy link
Collaborator

drazvan commented Jan 11, 2024

Thanks @smartestrobotdai ! I see that one of the commits is not signed. Can you maybe squash the two and force-push the branch? (and the new commit should be signed automatically).

Signed-off-by: smartestrobotdai <smartestrobotdai@gmail.com>
@magiccpp
Copy link
Contributor Author

@drazvan Thanks! I squashed the commits and forcely pushed, please check if it is good now.

Copy link
Collaborator

@drazvan drazvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 . Thanks!

@drazvan drazvan merged commit 68f5243 into NVIDIA:develop Jan 12, 2024
@onkarrajambatwar
Copy link

onkarrajambatwar commented Jan 17, 2024

@drazvan Could you please add exampl related to Azure LLM, may be sample config. Also, in which version I can see this change?

@drazvan drazvan assigned drazvan and trebedea and unassigned drazvan Jan 17, 2024
@trebedea
Copy link
Collaborator

trebedea commented Jan 17, 2024

@drazvan Could you please add exampl related to Azure LLM, may be sample config. Also, in which version I can see this change?

@onkarrajambatwar , doesn't this work for you? #249 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants