Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor float check bug in compute_num_steps_per_epoch #235

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

trias702
Copy link
Collaborator

What does this PR do ?

Fixed minor float check bug in compute_num_steps_per_epoch

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: Daniel Egert <degert@nvidia.com>
@trias702 trias702 requested a review from gshennvm July 12, 2024 23:45
@github-actions github-actions bot added the Utils label Jul 12, 2024
@trias702 trias702 merged commit 23752e7 into main Jul 12, 2024
5 checks passed
@trias702 trias702 deleted the degert/bugfix-142 branch July 12, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants