Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the protobuf version to solve incompatibility #738

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Fix the protobuf version to solve incompatibility #738

merged 1 commit into from
Jul 28, 2022

Conversation

IsaacYangSLA
Copy link
Collaborator

No description provided.

@IsaacYangSLA IsaacYangSLA marked this pull request as ready for review July 28, 2022 21:52
@YuanTingHsieh
Copy link
Collaborator

Fix #736

YuanTingHsieh
YuanTingHsieh approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh YuanTingHsieh linked an issue Jul 28, 2022 that may be closed by this pull request
run pip install nvflare==2.1.2 brings wrong protobuf version #736
Closed
@IsaacYangSLA IsaacYangSLA merged commit c3178d2 into NVIDIA:2.1 Jul 28, 2022
@IsaacYangSLA IsaacYangSLA deleted the fix_protobuf_version branch August 1, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run pip install nvflare==2.1.2 brings wrong protobuf version
2 participants
@IsaacYangSLA @YuanTingHsieh