Downgrade unused columns error to a warning #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating columns you don't use is still a bad idea, but it used to crash Triton when we were using Triton ensembles and now is mostly just going to cause the user headaches when they need to supply information that isn't actually used. Downgrading it to a warning will let people do this but still signal that it's a bad idea.
karlhigley
requested review from
oliverholworthy,
rnyak,
bschifferer and
jperez999
rnyak
approved these changes
Mar 28, 2023
Documentation preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating columns you don't use is still a bad idea, but it used to crash Triton when we were using Triton ensembles and now is mostly just going to cause the user headaches when they need to supply information that isn't actually used. Downgrading it to a warning will let people do this but still signal that it's a bad idea.