Allow selection of multiple outputs with SampleSoftmax #155
Conversation
nv-alaiacano
added
bug
Documentation preview |
Click to view CI ResultsGitHub pull request #155 of commit d53206034d9050d24cf2f8822a36de6e369d19b0, no merge conflicts.
Running as SYSTEM
Setting status of d53206034d9050d24cf2f8822a36de6e369d19b0 to PENDING with url https://10.20.13.93:8080/job/merlin_systems/167/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/155/*:refs/remotes/origin/pr/155/* # timeout=10
> git rev-parse d53206034d9050d24cf2f8822a36de6e369d19b0^{commit} # timeout=10
Checking out Revision d53206034d9050d24cf2f8822a36de6e369d19b0 (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f d53206034d9050d24cf2f8822a36de6e369d19b0 # timeout=10
Commit message: "add more tests"
> git rev-list --no-walk 6ebf6cba52aa6dc19397f0ff9c451d63a86b5dd7 # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins8950905476297710301.sh
PYTHONPATH=:/usr/local/lib/python3.8/dist-packages/:/usr/local/hugectr/lib:/var/jenkins_home/workspace/merlin_systems/systems
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 67 items
|
|
@nv-alaiacano I think one of the ensemble tests needs to be updated to match these changes (based on what I see from Jenkins) |
Click to view CI ResultsGitHub pull request #155 of commit 1f34a8c694bb69a73def361db2a91b7dda9bceef, no merge conflicts.
Running as SYSTEM
Setting status of 1f34a8c694bb69a73def361db2a91b7dda9bceef to PENDING with url https://10.20.13.93:8080/job/merlin_systems/169/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/155/*:refs/remotes/origin/pr/155/* # timeout=10
> git rev-parse 1f34a8c694bb69a73def361db2a91b7dda9bceef^{commit} # timeout=10
Checking out Revision 1f34a8c694bb69a73def361db2a91b7dda9bceef (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f 1f34a8c694bb69a73def361db2a91b7dda9bceef # timeout=10
Commit message: "fix typos in sampling op"
> git rev-list --no-walk 4cdf663e0c0d43574a0442d77c901f1d6d9f2815 # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins8518254697382694194.sh
PYTHONPATH=:/usr/local/lib/python3.8/dist-packages/:/usr/local/hugectr/lib:/var/jenkins_home/workspace/merlin_systems/systems
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 67 items
|
nv-alaiacano
force-pushed
the
laiacano/softmax-multiple-output
branch
from
1f34a8c
to
e9cfe4f
Compare
Click to view CI ResultsGitHub pull request #155 of commit e9cfe4f17817c2412f6791c81ad28f33a6437e3a, no merge conflicts.
Running as SYSTEM
Setting status of e9cfe4f17817c2412f6791c81ad28f33a6437e3a to PENDING with url https://10.20.13.93:8080/job/merlin_systems/204/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_systems
using credential fce1c729-5d7c-48e8-90cb-b0c314b1076e
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url https://github.com/NVIDIA-Merlin/systems # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/systems
> git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems user + githubtoken
> git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/systems +refs/pull/155/*:refs/remotes/origin/pr/155/* # timeout=10
> git rev-parse e9cfe4f17817c2412f6791c81ad28f33a6437e3a^{commit} # timeout=10
Checking out Revision e9cfe4f17817c2412f6791c81ad28f33a6437e3a (detached)
> git config core.sparsecheckout # timeout=10
> git checkout -f e9cfe4f17817c2412f6791c81ad28f33a6437e3a # timeout=10
Commit message: "fix typo in tests"
> git rev-list --no-walk a063aafca186aaf8d0351aabd791ced14c0bb9fc # timeout=10
[merlin_systems] $ /bin/bash /tmp/jenkins969718016192929246.sh
PYTHONPATH=:/usr/local/lib/python3.8/dist-packages/:/usr/local/hugectr/lib:/var/jenkins_home/workspace/merlin_systems/systems
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_systems/systems, configfile: pyproject.toml
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 69 items
|
This reverts commit 4563861.
This enables users to choose more than one output in
SampleSoftmax, in case it's desirable to have more than just theitem_id.It also makes a slight change to the output schema: the output schema will match the selected columns from the input schema. We previously specified the name as
ordered_idsand setis_list=Trueandis_ragged=True. Now those settings are all passed from the input, as well as the dtype.I also added some tests and found a potential issue with
_relevance_col_nameanddependencies- see the TODO note in the test file.Note that this is a somewhat breaking change if people are setting
_input_col="a string"manually. If that is a concern, I can rework the signature to maintain backwards compatibility.