Add multi-gpu github action tests using horovod #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
edknv
changed the title
|
@jperez999 fyi. do you mind reviewing? thanks. |
karlhigley
reviewed
Mar 8, 2023
| branch=main | ||
| if [[ $ref_type == "tag"* ]] | ||
| then | ||
| git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +refs/heads/release*:refs/remotes/origin/release* |
There was a problem hiding this comment.
Just curious, asking for my own edification: what's different in protocol.version=2?
There was a problem hiding this comment.
this was copied from other places that have this pattern. now available in the branch-name action here. The reason for the protocol.version=2 was to match what the GitHub actions/checkout does in the fetch. It may no longer be strictly necessary since the default protocol is v2 with recent versions of git.
There was a problem hiding this comment.
It looks like v2 enables more commands to be sent over a single connection, among other things: https://git-scm.com/docs/protocol-v2
karlhigley
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals ⚽
This PR adds a GitHub Actions workflow for multi-GPU tests.
Implementation Details 🚧
Testing Details 🔍
GitHub Actions workflow:
horovod (2GPU) / gpu-ci