Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert data formats before executing each op in LocalExecutor #280

Merged

Conversation

karlhigley
Copy link
Contributor

@karlhigley karlhigley commented Apr 12, 2023

This brings us closer to a point where we can get rid of the custom code for running NVTabular Workflows at serving time by incorporating some of the functionality found there directly into LocalExecutor. In particular, LocalExecutor now checks the data formats supported by each operator and converts the input data to one of the supported formats if necessary.

Depends on: #279

@karlhigley karlhigley self-assigned this Apr 12, 2023
@karlhigley karlhigley added clean up chore Maintenance for the repository labels Apr 12, 2023
@karlhigley karlhigley added this to the Merlin 23.04 milestone Apr 12, 2023
@karlhigley karlhigley changed the title Feature/data format conversion Data format conversion in LocalExecutor Apr 12, 2023
@karlhigley karlhigley changed the title Data format conversion in LocalExecutor Convert data formats before executing each op in LocalExecutor Apr 12, 2023
@karlhigley karlhigley modified the milestones: Merlin 23.04, Merlin 23.05 Apr 12, 2023
@karlhigley karlhigley marked this pull request as ready for review April 13, 2023 17:27
@karlhigley karlhigley force-pushed the feature/data-format-conversion branch from cc1d04c to 5a24861 Compare April 13, 2023 17:32
@karlhigley karlhigley modified the milestones: Merlin 23.05, Merlin 23.06 May 4, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/core/review/pr-280

@karlhigley karlhigley merged commit 5601766 into NVIDIA-Merlin:main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance for the repository clean up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants