Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update end-to-end example to use systems api #680

Merged
merged 14 commits into from
May 1, 2023

Conversation

radekosmulski
Copy link
Contributor

resolves #676

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

@rnyak rnyak self-requested a review April 24, 2023 14:50
@rnyak rnyak added this to the Merlin 23.05 milestone Apr 24, 2023
@radekosmulski radekosmulski changed the title [WIP] update end-to-end example to use systems api update end-to-end example to use systems api Apr 26, 2023
@radekosmulski radekosmulski changed the title update end-to-end example to use systems api [WIP] update end-to-end example to use systems api Apr 26, 2023
@radekosmulski radekosmulski marked this pull request as draft April 26, 2023 08:18
@@ -112,10 +112,10 @@
"name": "stderr",
Copy link
Contributor

@rnyak rnyak Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.    table = TensorTable.from_df(df.iloc[:100])

can you please add a new cell and add these two lines ( we need my PR to be merged first for the top_k part works ):

Let's now add a top_k parameter to model so that we can return the top k item ids with the highest scores when we serve the model on Triton Inference Server.

model.top_k = 28

model.eval()


Reply via ReviewNB

Copy link
Contributor

@rnyak rnyak Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2. table = TensorTable.from_df(df.iloc[:100])
can you please add a new cell and add these two lines ( we need my PR to be merged first for the top_k part works ):

Let's now add a top_k parameter to model so that we can return the top k item ids with the highest scores when we serve the model on Triton Inference Server.

model.top_k = 28

model.eval()

Reply via ReviewNB

you can set top_k 10 or something else, if you want. I set it to 28 just as an example.

@radekosmulski radekosmulski force-pushed the update_legacy_inference_example branch from 774430c to 62e1fbb Compare April 28, 2023 01:34
@radekosmulski radekosmulski marked this pull request as ready for review April 28, 2023 01:36
@radekosmulski radekosmulski changed the title [WIP] update end-to-end example to use systems api update end-to-end example to use systems api Apr 28, 2023
@rnyak rnyak merged commit 37b639d into main May 1, 2023
@rnyak rnyak deleted the update_legacy_inference_example branch May 1, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update Legacy Inference Example to use Merlin Systems + TorchScript
3 participants