-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing to pass in a vocab in Categorify #935
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
47d6570
Allow to pass in vocabs in Categorify to fix make_feature_column_work…
marcromeyn 110d1df
Update .gitignore
marcromeyn 4d32576
Addressing PR comments
marcromeyn 3ffc73f
Quick fix to try to make the tests pass
marcromeyn a80cdcb
Merge branch 'main' into feature-cols-categorify
benfred c5a82be
Update cpu-ci.yml
benfred 1ef8e43
Update nvtabular/ops/categorify.py
benfred 55e5ca9
Merge branch 'main' into feature-cols-categorify
benfred c3f615c
Merge branch 'main' into feature-cols-categorify
benfred feff50e
Merge branch 'main' into feature-cols-categorify
benfred f6183ac
Fixing prepend in dispatch._add_to_series
marcromeyn 456607a
Merge branch 'main' into feature-cols-categorify
marcromeyn 419b07f
Fixing flake8
marcromeyn ad2f61e
Merge branch 'main' into feature-cols-categorify
marcromeyn e4cf708
Merge branch 'main' into feature-cols-categorify
benfred 11f5b03
Fix to match frequency sorting categorify changes
benfred File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,46 +1,46 @@ | ||
name: CPU CI | ||
on: | ||
push: | ||
branches: [ main ] | ||
pull_request: | ||
branches: [ main ] | ||
jobs: | ||
build: | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
python-version: [3.8] | ||
os: [ubuntu-latest] | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install Ubuntu packages | ||
run: | | ||
sudo apt-get update -y | ||
sudo apt-get install -y protobuf-compiler | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip setuptools wheel | ||
python -m pip install -r requirements.txt pybind11 | ||
python -m pip install -r requirements-dev.txt | ||
- name: Lint with flake8 | ||
run: | | ||
flake8 . | ||
- name: Lint with black | ||
run: | | ||
black --check . | ||
- name: Lint with isort | ||
run: | | ||
isort -c . | ||
- name: Build | ||
run: | | ||
python setup.py develop | ||
- name: Run unittests | ||
run: | | ||
python -m pytest -svv tests/unit/test_cpu_workflow.py | ||
name: CPU CI | ||
|
||
on: | ||
push: | ||
branches: [ main ] | ||
pull_request: | ||
branches: [ main ] | ||
|
||
jobs: | ||
build: | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
python-version: [3.8] | ||
os: [ubuntu-latest] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
- name: Install Ubuntu packages | ||
run: | | ||
sudo apt-get update -y | ||
sudo apt-get install -y protobuf-compiler | ||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip setuptools wheel | ||
python -m pip install -r requirements.txt pybind11 | ||
python -m pip install -r requirements-dev.txt | ||
- name: Lint with flake8 | ||
run: | | ||
flake8 . | ||
- name: Lint with black | ||
run: | | ||
black --check . | ||
- name: Lint with isort | ||
run: | | ||
isort -c . | ||
- name: Build | ||
run: | | ||
python setup.py develop | ||
- name: Run unittests | ||
run: | | ||
python -m pytest -svv tests/unit/test_cpu_workflow.py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,3 +71,5 @@ ipython_config.py | |
.dmypy.json | ||
dmypy.json | ||
|
||
# PyCharm | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line fails if features have vocabularies of varying size. In particular, the sample notebook "using-feature-columns.ipynb" fails on this line with the following error. Am I missing anything, or this is a bug here?
I used docker image "merlin-tensorflow-training" that had nvtabular 0.6.1 installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on how to handle this @marcromeyn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reporting! That looks like a bug to me - I opened #1062 to track