Enable DatasetGen usage in CPU environment
#1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
This seems like a good fix for now 👍🏻
In the longer run, I think we'd like to consolidate the dataset generation code and probably favor the code in Merlin Models over this version. Not sure how much is here that MM doesn't have though, so possible we can just get rid of this version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
DatasetGenusage in CPU environment.I ran into an error from this function when running in a CPU environment where the offsets were trying to call cupy.cumsum on numpy data.