Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] LogOp for list features #1153

Closed
bschifferer opened this issue Oct 1, 2021 · 0 comments · Fixed by #1209
Closed

[FEA] LogOp for list features #1153

bschifferer opened this issue Oct 1, 2021 · 0 comments · Fixed by #1209
Assignees
@benfred

Comments

@bschifferer
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As a user, I want to be able to use the LogOp on a columns with list values.

Describe the solution you'd like
Example dataset:

df = cudf.DataFrame({'userid': ['a', 'b', 'c'], 'col': [[10,100,1000], [10,5], [50,10]]})

log_col = ['col'] >> nvt.ops.LogOp()

Log Operation should be applied to every value in the list.
@benfred benfred self-assigned this Oct 18, 2021
benfred added a commit to benfred/NVTabular that referenced this issue Oct 22, 2021
@benfred
Make LogOp work on list columns.
df0facf 
This change updates LogOp so that it can process continuous list columns,
as well as existing scalar columns.

Closes NVIDIA-Merlin#1153
@benfred benfred mentioned this issue Oct 22, 2021
Merged
benfred added a commit that referenced this issue Oct 25, 2021
@benfred
Make LogOp work on list columns. (#1209)
a17c6ad 
This change updates LogOp so that it can process continuous list columns,
as well as existing scalar columns.

Closes #1153
mikemckiernan pushed a commit that referenced this issue Nov 24, 2022
@benfred
Make LogOp work on list columns. (#1209)
a861279 
This change updates LogOp so that it can process continuous list columns,
as well as existing scalar columns.

Closes #1153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benfred benfred

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make LogOp work on list columns. benfred/NVTabular
2 participants
@benfred @bschifferer