Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feast to run on newest release version 0.31 #975

Merged
merged 9 commits into from
May 18, 2023

Conversation

jperez999
Copy link
Collaborator

This PR updates Merlin to run on latest version of feast by completing the following:

  • the multi stage examples to run on the latest version of feast
  • optimizes path variables
  • updates the merlin-ci container to pip install the latest version of feast
  • removed unnecessary imports (faiss and filtercandidate) that resulted from flake-nb checks.
  • updated the test_integration script in ci to pip install 0.31 version of feast.

For this PR to work, the following PR must be merged first: NVIDIA-Merlin/systems#344 because it updates the feast operator.

@jperez999 jperez999 added enhancement New feature or request chore Infrastructure update labels May 12, 2023
@jperez999 jperez999 self-assigned this May 12, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-975

@karlhigley
Copy link
Contributor

@jperez999 It looks like the tests are failing due to downstream notebook tests, which we definitely should be running but probably should not be part of a required PR check. I think I did that, but it needs further attention, because those tests (while informative) should not block this PR.

@jperez999 jperez999 merged commit 3aa13a6 into NVIDIA-Merlin:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Infrastructure update enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants