Pin dask/distributed package versions after other installs in CI image #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest attempt to build the CI container is ending up with `dask 2022.1.1`, which I think must be happening because of subsequent installs. Moving the install farther down the file to see if that helps.
karlhigley
requested review from
oliverholworthy,
jperez999 and
nv-alaiacano
Documentation preview |
oliverholworthy
approved these changes
Feb 27, 2023
Looks like it's because feast 0.19 which we install later depends on |
jperez999
reviewed
Feb 27, 2023
| @@ -21,6 +20,10 @@ RUN pip install astroid==2.5.6 'feast<0.20' sklearn | |||
| RUN echo 'import sphinx.domains' >> /usr/local/lib/python3.8/dist-packages/sphinx/__init__.py | |||
There was a problem hiding this comment.
Your downgrade of dask happens in feast<0.20. It has an anchored requirement for dask 2022.1 So yeah adding dask reinstall at the end should do the trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest attempt to build the CI container is ending up with
dask 2022.1.1, which I think must be happening because of subsequent installs. Moving the install farther down the file to see if that helps.