Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about building containers manually #793

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nv-alaiacano
Copy link
Contributor

Per some customer questions, we can add a guide for building the containers from the provided Dockerfiles.

I'm building now using the commands I used in the README and will validate that they work. Feedback on terminology or accuracy of the build stages is appreciated.

@nv-alaiacano nv-alaiacano added the documentation Improvements or additions to documentation label Jan 17, 2023
@nv-alaiacano nv-alaiacano added this to the Merlin 23.02 milestone Jan 17, 2023
@nv-alaiacano
Copy link
Contributor Author

note: tests do not need to run on this documentation-only PR so I canceled the compute-heavy ones.

@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-793

docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated

## Default Arguments

Each of the Dockerfiles have many `ARG`s defined, most of which have defaults set. Sometimes the defaults fall out of date, because the Merlin team overrides them in our build process as demonstrated above. To see the latest versions used in each of our containers, see the [Merlin Support Matrix](https://nvidia-merlin.github.io/Merlin/main/support_matrix/index.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be rephrase to see the latest versions as to see the latest release versions ?

Copy link
Member

@mikemckiernan mikemckiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, you find something helpful in there. Let me know what I can clarify.

docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jperez999 jperez999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the incorrect --build-arg assignment it looks good. Thanks for putting this together.

docker/README.md Outdated Show resolved Hide resolved
@nv-alaiacano nv-alaiacano added the skip-changelog Exclude from change log label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Exclude from change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants