Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytorch tritonserver backend to ci dockerfile #441

Merged
merged 4 commits into from
Jul 7, 2022

Conversation

jperez999
Copy link
Collaborator

Missing pytorch backend added to ensure support for pytorch models in inference on the merlin all in one.

@jperez999 jperez999 requested a review from karlhigley July 7, 2022 20:03
@jperez999 jperez999 self-assigned this Jul 7, 2022
@jperez999 jperez999 added bug Something isn't working ci labels Jul 7, 2022
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-441

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #441 of commit fd5ffff662931b2208f077453bd9804d2aa667a1, no merge conflicts.
Running as SYSTEM
Setting status of fd5ffff662931b2208f077453bd9804d2aa667a1 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/236/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/441/*:refs/remotes/origin/pr/441/* # timeout=10
 > git rev-parse fd5ffff662931b2208f077453bd9804d2aa667a1^{commit} # timeout=10
Checking out Revision fd5ffff662931b2208f077453bd9804d2aa667a1 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f fd5ffff662931b2208f077453bd9804d2aa667a1 # timeout=10
Commit message: "add pytorch backend to the ci container, should be supported"
 > git rev-list --no-walk cb66ff43546d25642d8c4a3005aecd58b481a1e7 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins14373542261350438073.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items

tests/unit/test_version.py . [ 50%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py . [100%]

======================== 2 passed in 145.55s (0:02:25) =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins7037689011033995205.sh

@jperez999 jperez999 requested a review from benfred July 7, 2022 20:46
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #441 of commit 6ce1158aab5e371c616e96e6b1d52a51399850d0, no merge conflicts.
Running as SYSTEM
Setting status of 6ce1158aab5e371c616e96e6b1d52a51399850d0 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/239/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/441/*:refs/remotes/origin/pr/441/* # timeout=10
 > git rev-parse 6ce1158aab5e371c616e96e6b1d52a51399850d0^{commit} # timeout=10
Checking out Revision 6ce1158aab5e371c616e96e6b1d52a51399850d0 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 6ce1158aab5e371c616e96e6b1d52a51399850d0 # timeout=10
Commit message: "Merge branch 'main' into fix-ci-dockerfile-1"
 > git rev-list --no-walk 3f0d332dce3a80d86abc017b0283f44c985ec79a # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins12767564279836422311.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 2 items

tests/unit/test_version.py . [ 50%]
tests/unit/examples/test_building_deploying_multi_stage_RecSys.py . [100%]

======================== 2 passed in 120.61s (0:02:00) =========================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins18324517860337289774.sh

Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm -

what are we using the triton pytorch backend for now? Last I remember we were using the python Triton backend for Pytorch

@jperez999 jperez999 merged commit e1b9f04 into NVIDIA-Merlin:main Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants