-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Readability improvements #440
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Click to view CI ResultsGitHub pull request #440 of commit cb66ff43546d25642d8c4a3005aecd58b481a1e7, no merge conflicts. Running as SYSTEM Setting status of cb66ff43546d25642d8c4a3005aecd58b481a1e7 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/235/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse cb66ff43546d25642d8c4a3005aecd58b481a1e7^{commit} # timeout=10 Checking out Revision cb66ff43546d25642d8c4a3005aecd58b481a1e7 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f cb66ff43546d25642d8c4a3005aecd58b481a1e7 # timeout=10 Commit message: "docs: Example readability improvements" > git rev-list --no-walk a11d27bd21fb5ceb1edc9f7d2504a1e7bbed8e03 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins16489494868401674948.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 2 items |
Documentation preview |
Click to view CI ResultsGitHub pull request #440 of commit b7bfb46270dcffbea3ee582e96556b85fab4e3b0, no merge conflicts. Running as SYSTEM Setting status of b7bfb46270dcffbea3ee582e96556b85fab4e3b0 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/242/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse b7bfb46270dcffbea3ee582e96556b85fab4e3b0^{commit} # timeout=10 Checking out Revision b7bfb46270dcffbea3ee582e96556b85fab4e3b0 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f b7bfb46270dcffbea3ee582e96556b85fab4e3b0 # timeout=10 Commit message: "Merge branch 'main' into readability" > git rev-list --no-walk 98f7f723fc38e6534be5649d54c1606331823d95 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins15412006313384700865.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 2 items |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the PR and the fixes.
Click to view CI ResultsGitHub pull request #440 of commit 24b50cae126003d40be8c4820f1d5fca3d4d52ac, no merge conflicts. Running as SYSTEM Setting status of 24b50cae126003d40be8c4820f1d5fca3d4d52ac to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/254/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse 24b50cae126003d40be8c4820f1d5fca3d4d52ac^{commit} # timeout=10 Checking out Revision 24b50cae126003d40be8c4820f1d5fca3d4d52ac (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 24b50cae126003d40be8c4820f1d5fca3d4d52ac # timeout=10 Commit message: "Merge branch 'main' into readability" > git rev-list --no-walk 1b54899459f3a4ec98239777930a8964df8a472b # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins8224902800114283977.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 2 items |
Click to view CI ResultsGitHub pull request #440 of commit a1d86739888e1525cf3bcbd957deef70308e9ec9, no merge conflicts. Running as SYSTEM Setting status of a1d86739888e1525cf3bcbd957deef70308e9ec9 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/288/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse a1d86739888e1525cf3bcbd957deef70308e9ec9^{commit} # timeout=10 Checking out Revision a1d86739888e1525cf3bcbd957deef70308e9ec9 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f a1d86739888e1525cf3bcbd957deef70308e9ec9 # timeout=10 Commit message: "Merge branch 'main' into readability" > git rev-list --no-walk 7a23a24e33e07e75c65884adeb66cec8bb3b78ed # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins1851448308459367363.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 2 items |
Click to view CI ResultsGitHub pull request #440 of commit b75a949f2a55b053db06534e7a74f7804afc7882, no merge conflicts. Running as SYSTEM Setting status of b75a949f2a55b053db06534e7a74f7804afc7882 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/293/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse b75a949f2a55b053db06534e7a74f7804afc7882^{commit} # timeout=10 Checking out Revision b75a949f2a55b053db06534e7a74f7804afc7882 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f b75a949f2a55b053db06534e7a74f7804afc7882 # timeout=10 Commit message: "Merge branch 'main' into readability" > git rev-list --no-walk 529c5cc693846f658c5f4bc58345c45d56abd6c5 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins4687341753394991512.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 2 items |
rerun tests |
Click to view CI ResultsGitHub pull request #440 of commit b75a949f2a55b053db06534e7a74f7804afc7882, no merge conflicts. Running as SYSTEM Setting status of b75a949f2a55b053db06534e7a74f7804afc7882 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/294/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse b75a949f2a55b053db06534e7a74f7804afc7882^{commit} # timeout=10 Checking out Revision b75a949f2a55b053db06534e7a74f7804afc7882 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f b75a949f2a55b053db06534e7a74f7804afc7882 # timeout=10 Commit message: "Merge branch 'main' into readability" > git rev-list --no-walk b75a949f2a55b053db06534e7a74f7804afc7882 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins13550551991265133490.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 2 items |
Signed-off-by: Ryan Russell <git@ryanrussell.org>
Signed-off-by: Ryan Russell <git@ryanrussell.org>
b75a949
to
ed0bc44
Compare
Click to view CI ResultsGitHub pull request #440 of commit ed0bc441e7308797ea57e9b6961b4182905ebca8, no merge conflicts. Running as SYSTEM Setting status of ed0bc441e7308797ea57e9b6961b4182905ebca8 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/299/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse ed0bc441e7308797ea57e9b6961b4182905ebca8^{commit} # timeout=10 Checking out Revision ed0bc441e7308797ea57e9b6961b4182905ebca8 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f ed0bc441e7308797ea57e9b6961b4182905ebca8 # timeout=10 Commit message: "docs: Example readability improvements" > git rev-list --no-walk 75b4ee4b4ab80a5a032a3eaaf88b71ea93ee21b4 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins5874860954489670366.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
rerun tests |
Click to view CI ResultsGitHub pull request #440 of commit ed0bc441e7308797ea57e9b6961b4182905ebca8, no merge conflicts. Running as SYSTEM Setting status of ed0bc441e7308797ea57e9b6961b4182905ebca8 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/300/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse ed0bc441e7308797ea57e9b6961b4182905ebca8^{commit} # timeout=10 Checking out Revision ed0bc441e7308797ea57e9b6961b4182905ebca8 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f ed0bc441e7308797ea57e9b6961b4182905ebca8 # timeout=10 Commit message: "docs: Example readability improvements" > git rev-list --no-walk ed0bc441e7308797ea57e9b6961b4182905ebca8 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins6973822478204931166.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
rerun tests |
Click to view CI ResultsGitHub pull request #440 of commit ed0bc441e7308797ea57e9b6961b4182905ebca8, no merge conflicts. Running as SYSTEM Setting status of ed0bc441e7308797ea57e9b6961b4182905ebca8 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/301/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse ed0bc441e7308797ea57e9b6961b4182905ebca8^{commit} # timeout=10 Checking out Revision ed0bc441e7308797ea57e9b6961b4182905ebca8 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f ed0bc441e7308797ea57e9b6961b4182905ebca8 # timeout=10 Commit message: "docs: Example readability improvements" > git rev-list --no-walk ed0bc441e7308797ea57e9b6961b4182905ebca8 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins11151039342888785853.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Between the time that Ryan opened this PR and the time that we've been able to address the build failures, the Criteo TIS with TF notebook was removed or renamed.
Click to view CI ResultsGitHub pull request #440 of commit 24ec50b91c077343ae97b54287bf4bb06584db7c, no merge conflicts. Running as SYSTEM Setting status of 24ec50b91c077343ae97b54287bf4bb06584db7c to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/302/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse 24ec50b91c077343ae97b54287bf4bb06584db7c^{commit} # timeout=10 Checking out Revision 24ec50b91c077343ae97b54287bf4bb06584db7c (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 24ec50b91c077343ae97b54287bf4bb06584db7c # timeout=10 Commit message: "Remove notebook that was revised" > git rev-list --no-walk ed0bc441e7308797ea57e9b6961b4182905ebca8 # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins709500297365627258.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
rerun tests |
Click to view CI ResultsGitHub pull request #440 of commit 24ec50b91c077343ae97b54287bf4bb06584db7c, no merge conflicts. Running as SYSTEM Setting status of 24ec50b91c077343ae97b54287bf4bb06584db7c to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/303/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse 24ec50b91c077343ae97b54287bf4bb06584db7c^{commit} # timeout=10 Checking out Revision 24ec50b91c077343ae97b54287bf4bb06584db7c (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 24ec50b91c077343ae97b54287bf4bb06584db7c # timeout=10 Commit message: "Remove notebook that was revised" > git rev-list --no-walk 24ec50b91c077343ae97b54287bf4bb06584db7c # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins7906783662053242217.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
rerun tests |
Click to view CI ResultsGitHub pull request #440 of commit 24ec50b91c077343ae97b54287bf4bb06584db7c, no merge conflicts. Running as SYSTEM Setting status of 24ec50b91c077343ae97b54287bf4bb06584db7c to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/304/console and message: 'Pending' Using context: Jenkins Building on master in workspace /var/jenkins_home/workspace/merlin_merlin using credential systems-login > git rev-parse --is-inside-work-tree # timeout=10 Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10 Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin > git --version # timeout=10 using GIT_ASKPASS to set credentials login for merlin-systems > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/440/*:refs/remotes/origin/pr/440/* # timeout=10 > git rev-parse 24ec50b91c077343ae97b54287bf4bb06584db7c^{commit} # timeout=10 Checking out Revision 24ec50b91c077343ae97b54287bf4bb06584db7c (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 24ec50b91c077343ae97b54287bf4bb06584db7c # timeout=10 Commit message: "Remove notebook that was revised" > git rev-list --no-walk 24ec50b91c077343ae97b54287bf4bb06584db7c # timeout=10 [merlin_merlin] $ /bin/bash /tmp/jenkins17666149064179025701.sh ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, cov-3.0.0 collected 3 items |
Readability fixes in the examples. One small fix in the readme.