Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matplotlib to torch container #386

Merged
merged 28 commits into from
Jun 13, 2022
Merged

Conversation

jperez999
Copy link
Collaborator

This package is required by fastai now. So our fastai based notebooks fail, looking for matplotlib as a dependency.

@jperez999 jperez999 self-assigned this Jun 13, 2022
@jperez999 jperez999 added the bug Something isn't working label Jun 13, 2022
@jperez999 jperez999 added the ci label Jun 13, 2022
@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #386 of commit 966e8ffde251a13bf2a63c4fde7e54f8855238fc, no merge conflicts.
Running as SYSTEM
Setting status of 966e8ffde251a13bf2a63c4fde7e54f8855238fc to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/148/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/386/*:refs/remotes/origin/pr/386/* # timeout=10
 > git rev-parse 966e8ffde251a13bf2a63c4fde7e54f8855238fc^{commit} # timeout=10
Checking out Revision 966e8ffde251a13bf2a63c4fde7e54f8855238fc (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 966e8ffde251a13bf2a63c4fde7e54f8855238fc # timeout=10
Commit message: "add matplotlib for fastai"
 > git rev-list --no-walk acbff8d02cf169f68e8d0a1bae5ae1e363ee1238 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins14581257122214041291.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins15687323571956320914.sh

@jperez999 jperez999 added this to the Merlin 22.06 milestone Jun 13, 2022
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-386

@karlhigley karlhigley merged commit 04135d0 into NVIDIA-Merlin:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants