Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding instructions for running the E2E example on CPU #332

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

AshishSardana
Copy link
Contributor

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nvidia-merlin-bot
Copy link
Contributor

Click to view CI Results
GitHub pull request #332 of commit d4d691233e4b35108b8ea4ba8bb25b6231b849f9, no merge conflicts.
Running as SYSTEM
Setting status of d4d691233e4b35108b8ea4ba8bb25b6231b849f9 to PENDING with url https://10.20.13.93:8080/job/merlin_merlin/104/console and message: 'Pending'
Using context: Jenkins
Building on master in workspace /var/jenkins_home/workspace/merlin_merlin
using credential systems-login
 > git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Merlin # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Merlin
 > git --version # timeout=10
using GIT_ASKPASS to set credentials login for merlin-systems
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Merlin +refs/pull/332/*:refs/remotes/origin/pr/332/* # timeout=10
 > git rev-parse d4d691233e4b35108b8ea4ba8bb25b6231b849f9^{commit} # timeout=10
Checking out Revision d4d691233e4b35108b8ea4ba8bb25b6231b849f9 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f d4d691233e4b35108b8ea4ba8bb25b6231b849f9 # timeout=10
Commit message: "Adding intructions for running the example on CPU"
 > git rev-list --no-walk 32beacb1b04538a2a7b50619b2fcc3fc343ac095 # timeout=10
[merlin_merlin] $ /bin/bash /tmp/jenkins8986423641304128163.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/merlin_merlin/merlin
plugins: anyio-3.5.0, xdist-2.5.0, forked-1.4.0, cov-3.0.0
collected 1 item

tests/unit/test_version.py . [100%]

============================== 1 passed in 0.01s ===============================
Performing Post build task...
Match found for : : True
Logical operation result is TRUE
Running script : #!/bin/bash
cd /var/jenkins_home/
CUDA_VISIBLE_DEVICES=1 python test_res_push.py "https://github.com/gitapi/repos/NVIDIA-Merlin/Merlin/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"
[merlin_merlin] $ /bin/bash /tmp/jenkins6800573646506576663.sh

@karlhigley karlhigley requested a review from rnyak May 25, 2022 19:44
@rnyak
Copy link
Contributor

rnyak commented May 31, 2022

@AshishSardana can you also remove Please follow the instructions in the README.md file to install these libraries sentence? it is not valid anymore since we install in the notebook. thanks.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-332

@AshishSardana
Copy link
Contributor Author

@rnyak thanks for your review! I've resolved all the comments.

@rnyak rnyak merged commit 0d093d1 into NVIDIA-Merlin:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants