Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package check for tests #1056

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

jperez999
Copy link
Collaborator

@jperez999 jperez999 commented Jul 12, 2023

This PR adds checks to two new tests for packages required by the notebooks run within the tests. It ensures to only run these notebooks in the correct environments. It also fixes some formatting/linting errors about line lengths and comparison formats.

@jperez999 jperez999 added bug Something isn't working chore Infrastructure update ci labels Jul 12, 2023
@jperez999 jperez999 added this to the Merlin 23.07 milestone Jul 12, 2023
@jperez999 jperez999 self-assigned this Jul 12, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-1056

@jperez999 jperez999 merged commit 9079211 into NVIDIA-Merlin:main Jul 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Infrastructure update ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant