Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update merlin-tensorflow image to 23.08 in sagemaker example #1040

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edknv
Copy link
Contributor

@edknv edknv commented Jul 3, 2023

This PR updates the sagemaker example to use the latest merlin-tensorflow:23.08 image. Due to changes in triton/systems,

serve file that ships with the triton container is patched and we build our container with this patched version. Specifically, lines 143-167 that were used for disallowing multiple models are removed, and also --model-control-mode=explicit is removed from the last line.

Note also that the training script train.py is updated to reflect the latest changes in the nvtabular workflow.

@edknv edknv added documentation Improvements or additions to documentation enhancement New feature or request examples Adding new examples labels Jul 3, 2023
@edknv edknv self-assigned this Jul 3, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-1040

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 14, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@edknv edknv changed the title [WIP] Update merlin-tensorflow image to 23.06 in sagemaker example Update merlin-tensorflow image to 23.08 in sagemaker example Oct 26, 2023
@edknv edknv marked this pull request as ready for review October 26, 2023 01:02
@edknv edknv requested a review from rnyak October 26, 2023 01:03
@rnyak rnyak requested a review from jperez999 October 26, 2023 13:55
@rnyak
Copy link
Contributor

rnyak commented Oct 26, 2023

@jperez999 would you mind reviewing the changes? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request examples Adding new examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants