fix feast repo name in building-and-deploying-multi-stage-RecSys examples #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation preview |
nv-alaiacano
approved these changes
Jun 20, 2023
oliverholworthy
approved these changes
Jun 20, 2023
jperez999
previously requested changes
Jun 20, 2023
...g-and-deploying-multi-stage-RecSys/02-Deploying-multi-stage-RecSys-with-Merlin-Systems.ipynb
Outdated
Show resolved
Hide resolved
...g-and-deploying-multi-stage-RecSys/02-Deploying-multi-stage-RecSys-with-Merlin-Systems.ipynb
Outdated
Show resolved
Hide resolved
.../Building-and-deploying-multi-stage-RecSys/01-Building-Recommender-Systems-with-Merlin.ipynb
Outdated
Show resolved
Hide resolved
karlhigley
dismissed
jperez999’s stale review
Changes have been made, trying to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get this error
AttributeError: module 'feast' has no attribute 'FeatureStore'from this linefeature_store = feast.FeatureStore(feast_repo_path)the reason for that is because the name of the subdirectory is feast . And if the working directory is the directory where the feature store was created, then,import feastimports that directory, and not feast library the package.this PR fixes the feature store repo name, and also removes the version of
feastthat we recommend users to install.