Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix applicant flow for acceptance #134

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Fix applicant flow for acceptance #134

merged 4 commits into from
Jul 15, 2023

Conversation

michaelseyo
Copy link
Contributor

@michaelseyo michaelseyo commented Jul 15, 2023

Description

Changes made:

  1. Upon acceptance from the applicant, the applicant will be redirected to the update information page under the route /update-info
  2. Once the submit button is clicked on the update information page, the applicant will be logged out as nextauth requires a re-login to update the value of isApplicant. The reason for this is that the role: Applicant which we use for identifying applicants is now updated to the role: <Accepted Role>, and nextAuth uses the boolean of isApplicant = applicant.role == 'Applicant' to separate applicants from fintech members.
  3. The Update Information tab in the Applicant's view of the navbar is now removed as we'd use the update information page under the update-info route purely for when the applicant accepts the role and has to update their information.
  4. Removed the Accepted status from the director's Manage Applicant page, as the applicants are the ones that have control over this status and not the directors. The directors will give the Offered status for applicants.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@michaelseyo michaelseyo changed the title fix applicant flow for acceptance Fix applicant flow for acceptance Jul 15, 2023
@woowenjun99 woowenjun99 merged commit bb43725 into main Jul 15, 2023
@woowenjun99 woowenjun99 deleted the applicant-flow-fix branch July 15, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants