Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More user-friendly controls #57

Merged
merged 23 commits into from
Jan 30, 2024

Conversation

thomaswmorris
Copy link
Collaborator

@thomaswmorris thomaswmorris commented Jan 12, 2024

Some improvements to the UX:

  • Separate "search" bounds (where to look) and "trust" bounds (where to use/ignore data from).
  • Can now target an interval for the value of some objective
  • Log transforms in DOFs
  • Targeting constraints in objectives, so that the agent aims for some interval.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks, @thomaswmorris!
Just a couple of minor suggestions below. Feel free to merge after accepting them.

blop/dofs.py Outdated Show resolved Hide resolved
blop/dofs.py Show resolved Hide resolved
blop/objectives.py Outdated Show resolved Hide resolved
thomaswmorris and others added 3 commits January 30, 2024 18:23
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
Co-authored-by: Max Rakitin <mrakitin@users.noreply.github.com>
@thomaswmorris thomaswmorris merged commit 6eadfc1 into NSLS-II:main Jan 30, 2024
5 checks passed
thomaswmorris added a commit to thomaswmorris/blop that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants