Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

312 bug fix update geostationary readers to support multiple scan times #427

Open
wants to merge 84 commits into
base: main
Choose a base branch
from

Conversation

srikanth-kumar
Copy link
Collaborator

@srikanth-kumar srikanth-kumar commented Feb 1, 2024

passes_seviri.WV-Upper.unprojected_image.log
passes_abi.static.Infrared.imagery_annotated.log
passes_ahi.tc.WV.geotiff.log

The test scripts in this branch were failing by default before my code addition I took @mindyls advice and did merge the v1.12.0-release branch into this. The three files attached above are the results of successful tests for:

  1. $GEOIPS_PACKAGES_DIR/geoips/tests/scripts/abi.static.Infrared.imagery_annotated.sh
  2. $GEOIPS_PACKAGES_DIR/geoips/tests/scripts/ahi.tc.WV.geotiff.sh
  3. $GEOIPS_PACKAGES_DIR/geoips/tests/scripts/seviri.WV-Upper.unprojected_image.sh

Reviewer Checklist

PR author: Please ensure you meet all of the below requirements, and check boxes appropriately.

Reviewers: Please confirm all required testing/documentation has been completed prior to approving.

Remove lines that are not applicable, explain if you select "NO REQUIRED"

  • Required existing tests pass (ie full_test.sh, others as appropriate)
  • NO REQUIRED existing tests (explain why not required)
  • Required unit tests added and pass for new/modified functionality
  • NO REQUIRED unit tests (explain why not required)
  • Required integration tests added and pass for new/modified functionality
  • NO REQUIRED integration tests (explain why not required)
  • Required documentation added for new/modified functionality
  • NO REQUIRED documentation (explain why not required)
  • Required release notes added for new/modified functionality
  • NO REQUIRED release notes (explain why not required)
  • Required updates to other repos complete
  • NO REQUIRED updates to other repos (explain why not required)

https://github.com/NRLMMD-GEOIPS/.github/blob/main/.github/review-template.md

Related Issues

fixes NRLMMD-GEOIPS/geoips#NNN

Testing Instructions

Summary

Output

jsolbrig and others added 12 commits September 1, 2023 12:28
If only one scan time is provided, return only 2D dataset
Otherwise datasets along a time dimension
#312
…e-scan-times' of https://github.com/nrlmmd-geoips/geoips into 312-bug-fix-update-abi-netcdf-reader-to-read-in-multiple-scan-times
Without the leading /, flake8 would fail from certain directories.
Sometimes it would fail when running from within the repo, sometimes it would
faile when running from OUTSIDE the repo.  With the leading /, it seems to
pass from anywhere.
@jsolbrig jsolbrig changed the base branch from dev-staging to main October 22, 2024 20:27
@evrose54
Copy link
Contributor

See issue #802.

@evrose54
Copy link
Contributor

See issue #803.

@evrose54
Copy link
Contributor

See issue #804.

@evrose54
Copy link
Contributor

evrose54 commented Oct 23, 2024

After running full test, these checks fail for me with the new changes. We should likely update the expected output of these tests to include our new changes. Technically, the source_file_names attribute is wrong, as it references all test datasets initially sent to the reader, but I've tested trying to only gather the needed file names and this is throwing a wrench in things and is very complex. We might want to talk about that more. Nonetheless, all other tests pass, so this is more of a concern about metadata rather than correct functionality.

Failing tests:

abi.config_based_output_low_memory.sh
abi.config_based_output.sh
abi.tc.Visible.imagery_clean.sh

ami.tc.WV.geotiff.sh is also failing for me but that is not a cause of this PR. This has been happening for a long time even on main for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants