-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
312 bug fix update geostationary readers to support multiple scan times #427
base: main
Are you sure you want to change the base?
312 bug fix update geostationary readers to support multiple scan times #427
Conversation
If only one scan time is provided, return only 2D dataset Otherwise datasets along a time dimension #312
…e-scan-times' of https://github.com/nrlmmd-geoips/geoips into 312-bug-fix-update-abi-netcdf-reader-to-read-in-multiple-scan-times
Without the leading /, flake8 would fail from certain directories. Sometimes it would fail when running from within the repo, sometimes it would faile when running from OUTSIDE the repo. With the leading /, it seems to pass from anywhere.
…readers-to-support-multiple-scan-times
To ensure the correct version of the geoips code base, reference the GEOIPS_ACTIVE_BRANCH organization variable. This allows updating the geoips branch to use for actions if updates are made to the workflows.
…ers-to-support-multiple-scan-times
…tiple-scan-times' of https://github.com/NRLMMD-GeoIPS/geoips into 312-bug-fix-update-geostationary-readers-to-support-multiple-scan-times
…tiple-scan-times' into ami-ewsg-multi-scan-time
…ers-to-support-multiple-scan-times
…support-multiple-scan-times
…tiple-scan-times' into ami-ewsg-multi-scan-time
…support-multiple-scan-times
See issue #802. |
See issue #803. |
See issue #804. |
After running full test, these checks fail for me with the new changes. We should likely update the expected output of these tests to include our new changes. Technically, the Failing tests:
|
passes_seviri.WV-Upper.unprojected_image.log
passes_abi.static.Infrared.imagery_annotated.log
passes_ahi.tc.WV.geotiff.log
The test scripts in this branch were failing by default before my code addition I took @mindyls advice and did merge the v1.12.0-release branch into this. The three files attached above are the results of successful tests for:
Reviewer Checklist
PR author: Please ensure you meet all of the below requirements, and check boxes appropriately.
Reviewers: Please confirm all required testing/documentation has been completed prior to approving.
Remove lines that are not applicable, explain if you select "NO REQUIRED"
https://github.com/NRLMMD-GEOIPS/.github/blob/main/.github/review-template.md
Related Issues
fixes NRLMMD-GEOIPS/geoips#NNN
Testing Instructions
Summary
Output