Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Update geostationary readers to support multiple scan times #312

Open
3 tasks done
cpcamacho opened this issue Sep 1, 2023 · 3 comments
Open
3 tasks done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cpcamacho
Copy link
Contributor

cpcamacho commented Sep 1, 2023

Requested Update

Description

  • The geostationary readers currently only support reading in one scan time. They should be capable of reading in multiple scan times.

Background and Motivation

  • Follow geostationary readers need to be updated to support multiple scan times:
  • abi_netcdf
  • ahi_hsd
  • seviri_hrit
  • Easiest path forward will be to simply place a wrapper around the main ingest function in these readers, and loop through files grouped by scan time

Alternative Solutions

  • Leverage future satpy reader

Environment

  • geoips >= 1.11.3a0

Code to demonstrate issue

  • Run following test scripts to make sure we do not break existing functionality
  • $GEOIPS_PACKAGES_DIR/geoips/tests/scripts/abi.static.Infrared.imagery_annotated.sh
  • $GEOIPS_PACKAGES_DIR/geoips/tests/scripts/ahi.tc.WV.geotiff.sh
  • $GEOIPS_PACKAGES_DIR/geoips/tests/scripts/seviri.WV-Upper.unprojected_image.sh

Checklist for Completion

  • Update abi_netcdf reader
  • Update ahi_hsd reader
  • Update seviri_hrit reader
@cpcamacho cpcamacho added the bug Something isn't working label Sep 1, 2023
cpcamacho pushed a commit that referenced this issue Sep 1, 2023
If only one scan time is provided, return only 2D dataset
Otherwise datasets along a time dimension
#312
@cpcamacho cpcamacho changed the title Bug Fix: Update ABI NetCDF reader to read in multiple scan times Bug Fix: Update geostationary readers to support in multiple scan times Sep 7, 2023
@cpcamacho cpcamacho changed the title Bug Fix: Update geostationary readers to support in multiple scan times Bug Fix: Update geostationary readers to support multiple scan times Sep 7, 2023
@mindyls mindyls added this to the 2023 November milestone Nov 2, 2023
@mindyls mindyls added the Priority High High priority issues label Dec 14, 2023
@mindyls
Copy link
Contributor

mindyls commented Dec 14, 2023

@cpcamacho We can help @srikanth-kumar @Srikant-Kumar-Gampa with this. He will start looking through your linked branch here, get familiar with what it is doing, and ask as he has questions.

@evrose54 will share his GLM reader that currently loops through multiple scan times (this is handled differently, but may help inform development)

@mindyls
Copy link
Contributor

mindyls commented Jan 18, 2024

This is Kumar. Again, should add him so we can tag. ABI and AHI done. working on SEVIRI

@jsolbrig jsolbrig assigned srikanth-kumar and unassigned mindyls and cpcamacho Feb 1, 2024
@jsolbrig jsolbrig removed the Priority High High priority issues label Feb 1, 2024
@srikanth-kumar
Copy link
Collaborator

Clears the tests listed and ready for review through this pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants