-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API goes down on invalid YAML #153
Comments
Related to it being possible to enter invalid error data (but valid YAML) via the web UI: NREL/api-umbrella#153 In these cases, we will now return the default internal server error, which at least prevents bad error responses without an HTTP status code at all, which could really throw some clients for a tizzy.
This ensures that the error data isn't an unexpected type at the root like a string: NREL/api-umbrella#153
Thanks for reporting this and your help tracking it down. As we discussed, the issue was caused if you entered something like I was pushing some other updates live, so I went ahead and added some fixes for this:
Thanks again! |
I accidentally set Error Data / API Key Missing to a string that wasn't valid YAML. This seems to have thrown an caught error somewhere, because our entire API went down until I fixed the markup. I would expect the admin interface to refuse any invalid markup to protect careless people like me from themselves.
The text was updated successfully, but these errors were encountered: