Add option to manually override data directory #71
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 92.98% 92.98% -0.01%
==========================================
Files 15 16 +1
Lines 3351 3363 +12
==========================================
+ Hits 3116 3127 +11
- Misses 235 236 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
daniel-thom
reviewed
Feb 22, 2024
| end | ||
| end | ||
|
|
||
| const DATA_DIR = get_data_dir() |
There was a problem hiding this comment.
Are you sure about this? Won’t it get cached the first time and then not re-evaluated?
There was a problem hiding this comment.
Yes, it will, and this may necessitate another approach — see the initial PR comment above.
There was a problem hiding this comment.
Sorry, didn’t read that all the way through - or your comment above the function. I think the current behavior will be too confusing and that you will have to replace every use of DATA_DIR with a function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54. Here I have opted to check for the environment variable at the point where the existing
const DATA_DIRis defined. This gets bound up in the precompilation such that if a user wants to redefine the data directory after precompilation, they would have to manually re-compile withBase.compilecache(Base.identify_package("PowerSystemCaseBuilder")). If that is acceptable, I'll go ahead and write the documentation for how to use this new feature. If not, we will probably have to replace uses ofDATA_DIRwith calls to a function that checks the environment variable each time; I am not opposed to this but I thought I'd be conservative with my first pass.