add new 2 rto systems #70
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 92.71% 92.98% +0.27%
==========================================
Files 15 15
Lines 3143 3351 +208
==========================================
+ Hits 2914 3116 +202
- Misses 229 235 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| ), | ||
| ) | ||
| # change number | ||
| PSY.set_number!(b, PSY.get_number(b) + 10000) |
There was a problem hiding this comment.
This is likely a longstanding problem. Bus numbers are stored in the system. If you change it like this, problems will occur with the functions that rely on sys.bus_numbers.
There was a problem hiding this comment.
Should we open an issue in PSY to comment on this?
There was a problem hiding this comment.
I don't have the background knowledge to be able to comment here, but it seems like this should be resolved some way or another (# TODO comment?) prior to merge. Also, what is going on with the magic number?
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| ), | ||
| ) | ||
| # change number | ||
| PSY.set_number!(b, PSY.get_number(b) + 10000) |
There was a problem hiding this comment.
I don't have the background knowledge to be able to comment here, but it seems like this should be resolved some way or another (# TODO comment?) prior to merge. Also, what is going on with the magic number?
No description provided.