Fix bug in custom indexing for realized results

[daniel-thom]

This bug was introduced in commit
21f6dff. Passing custom values of start_time and len that cause the code to span arrays from two initial times caused an array indexing error.

[github-actions]

Performance Results

Version	Precompile Time
Main	7.906071261
This Branch	7.976583809

Version	Build Time
Main-Build Time Precompile	76.49312769
Main-Build Time Postcompile	3.931001996
This Branch-Build Time Precompile	74.659042934
This Branch-Build Time Postcompile	3.902061159

[codecov]

Codecov Report

Merging #995 (a262204) into main (4ae2f67) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #995      +/-   ##
==========================================
- Coverage   81.35%   81.31%   -0.04%     
==========================================
  Files         116      116              
  Lines       12119    12076      -43     
==========================================
- Hits         9859     9820      -39     
+ Misses       2260     2256       -4     

Flag	Coverage Δ
unittests	81.31% <100.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
src/simulation/realized_meta.jl	93.18% <100.00%> (+0.15%)	⬆️

... and 17 files with indirect coverage changes

[josephmckinsey]

This new code makes a lot more sense than the old row indexing. I couldn't test on my own data since it's still on PSI 0.20.4